Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1297: Media: Verify images are using optimized styles #351

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Jul 12, 2023

YALB-1297: Media: Verify images are using optimized styles

Description of work

  • CTA Banners = 🟣 - minor change added to PR
  • Grand Hero = ✔️ (no changes needed)
  • Image / Content Image = ✔️ (no changes needed)
  • Content Spotlight = 🟣 - minor change added to PR
  • Custom Cards & Media Grid / 3:2 card secondary = 🟣 - minor change added to PR
  • Views - Posts - List/Grid 3:2 card list = 🟣 - minor change added to PR
  • Card List Featured | Responsive image style = 🔴 - minor change added to PR - However, this style is not currently in use.

Functional testing steps:

Desktop

yalb-1297-reponsive-images.mp4

Mobile

yalb-1297-reponsive-images-mobile.mp4
  • Verify appropriately sized images are served for each component. Some images may be served slightly larger (<= 200px) than the exact pixel value, but that is because the image style is used for varying-width components. For example, the Content Spotlight can have a medium or large image size, or the focus can change. An image size was chosen based on the larger of the two required image sizes.

@joetower joetower changed the title fix(yalb-1297): update image styles YALB-1297: Media: Verify images are using optimized styles Jul 12, 2023
@joetower joetower self-assigned this Jul 12, 2023
@github-actions
Copy link

Visit Site

Created multidev environment pr-351 for yalesites-platform.

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat to see; I've not dealt with images in Drupal much. It all looks to load the different versions fine.

@nJim nJim merged commit 6b16523 into develop Jul 14, 2023
3 checks passed
@nJim nJim deleted the yalb-1297-images branch July 14, 2023 13:53
@nJim nJim mentioned this pull request Jul 14, 2023
@nJim nJim mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants