fix: make query for filteredRecords when totalRecords was manually set #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JurianArie
commented
Jul 9, 2024
There was a problem hiding this comment.
The changes from c37494f to the tests have been reverted, the optimalization should not have changed this behavior.
|
Thank you for the PR, I will review this as soon as I can. |
|
@Arkhas it seems like the PR you've sent is being reverted on this change. Would you mind reviewing and approving this? Thanks! |
JurianArie
changed the title
|
I confirmed one less query after the patch. This is a good optimization trick for large datasets. Thanks! Released on 11.1.3 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we always use
setTotalRecords(0)since we only show the filtered records count. After upgrading to Laravel 11 we noticed that our pagination stopped working. This seems to be caused by c37494f. This PR changes the logic to always query the filtered count if the total count was set manually.