Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recordsFiltered Limit (Hard Limit in Config) #2565

Closed
wants to merge 5 commits into from

Conversation

saaiful
Copy link

@saaiful saaiful commented Jan 16, 2021

Hard Limit in Config (for Pagination)

Part 1 > Part 2 is in laravel-datatables-html yajra/laravel-datatables-html#156

@mx-advaud
Copy link

This is very important. I would very much like to be able to use this feature.

@yajra yajra changed the title https://github.com/yajra/laravel-datatables/issues/2493 feat: recordsFiltered Limit (Hard Limit in Config) Feb 20, 2023
@gemul
Copy link

gemul commented Aug 12, 2024

Hi, when will this feature be implemented? This is rather high security risk for the server, where end user can arbitrarily set the "length" parameter to very large number upon request and lead to high load of the server.

@yajra yajra changed the base branch from 9.0 to master August 17, 2024 04:00
@yajra
Copy link
Owner

yajra commented Aug 17, 2024

My apologies for not being able to prioritize this. I tried changing the base to master but there seem to be conflicts.

Please submit a new PR or fix this if possible. Will also try to implement when I got the chance.

Copy link

@gemul
Copy link

gemul commented Aug 26, 2024

My apologies for not being able to prioritize this. I tried changing the base to master but there seem to be conflicts.

Please submit a new PR or fix this if possible. Will also try to implement when I got the chance.

Hi, I've submitted a PR for this issue. Please take a look when you get a chance.

Let me know if you need any further adjustments!

#3171

@yajra
Copy link
Owner

yajra commented Sep 9, 2024

I am closing this in favor of #3171, Thanks!

@yajra yajra closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants