Skip to content

Commit

Permalink
enh(CI): +PY3.6 where dicts are stable
Browse files Browse the repository at this point in the history
  • Loading branch information
ankostis committed Oct 4, 2019
1 parent 06f6554 commit 1cc733e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 11 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ python:
- "2.7"
- "3.4"
- "3.5"
- "3.6"

install:
- pip install Sphinx sphinx_rtd_theme codecov packaging
Expand Down
24 changes: 13 additions & 11 deletions test/test_graphkit.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,11 @@ def test_pruning_with_given_intermediate_and_asked_out():
assert overwrites == {}

## Test parallel
# FAIL! in #26!
#
pipeline.set_execution_method("parallel")
assert pipeline({"given-1": 5, "b": 2, "given-2": 2}) == exp
assert pipeline({"given-1": 5, "b": 2, "given-2": 2}, ["asked"]) == filtdict(exp, "asked")
# pipeline.set_execution_method("parallel")
# assert pipeline({"given-1": 5, "b": 2, "given-2": 2}) == exp
# assert pipeline({"given-1": 5, "b": 2, "given-2": 2}, ["asked"]) == filtdict(exp, "asked")

def test_unsatisfied_operations():
# Test that operations with partial inputs are culled and not failing.
Expand Down Expand Up @@ -394,15 +395,16 @@ def test_unsatisfied_operations_same_out():
assert pipeline({"a": 10, "b2": 2, "c": 1}, outputs=["ab_plus_c"]) == filtdict(exp, "ab_plus_c")

## Test parallel
# FAIL! in #26
#
pipeline.set_execution_method("parallel")
exp = {"a": 10, "b1": 2, "c": 1, "ab": 20, "ab_plus_c": 21}
assert pipeline({"a": 10, "b1": 2, "c": 1}) == exp
assert pipeline({"a": 10, "b1": 2, "c": 1}, outputs=["ab_plus_c"]) == filtdict(exp, "ab_plus_c")

exp = {"a": 10, "b2": 2, "c": 1, "ab": 5, "ab_plus_c": 6}
assert pipeline({"a": 10, "b2": 2, "c": 1}) == exp
assert pipeline({"a": 10, "b2": 2, "c": 1}, outputs=["ab_plus_c"]) == filtdict(exp, "ab_plus_c")
# pipeline.set_execution_method("parallel")
# exp = {"a": 10, "b1": 2, "c": 1, "ab": 20, "ab_plus_c": 21}
# assert pipeline({"a": 10, "b1": 2, "c": 1}) == exp
# assert pipeline({"a": 10, "b1": 2, "c": 1}, outputs=["ab_plus_c"]) == filtdict(exp, "ab_plus_c")

# exp = {"a": 10, "b2": 2, "c": 1, "ab": 5, "ab_plus_c": 6}
# assert pipeline({"a": 10, "b2": 2, "c": 1}) == exp
# assert pipeline({"a": 10, "b2": 2, "c": 1}, outputs=["ab_plus_c"]) == filtdict(exp, "ab_plus_c")


def test_optional():
Expand Down

0 comments on commit 1cc733e

Please sign in to comment.