Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensions to hook into the get/set content #1349

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dmx-patrick
Copy link

@dmx-patrick dmx-patrick commented Jul 18, 2017

Updated all methods that set/get the editor content, extensions can change the html that is being set/get.

Moved the extension init before the addElements method to allow
extension hook into the setContent and getContent. Because of the move
the elements are not available in the extension init method, the
extension should subscribe to the add addElement and removeElement
events.

Always enable toolbar when not disabled in options, even when all
elements on page have data-disable-toolbar set, it is possible that
elements are added later that require the toolbar.

Q A
Bug fix? yes
New feature? yes
BC breaks? no (could break some extensions that don't check if new elements are added)
Deprecations? no
New tests added? yes
Fixed tickets #976 and #1348
License MIT

Description

Extensions can manipulate the html set/get from the editor

--

Please, don't submit /dist files with your PR!

…hange the html that is being set/get.

Moved the extension init before the addElements method to allow
extension hook into the setContent and getContent. Because of the move
the elements are not available in the extension init method, the
extension should subscribe to the add addElement and removeElement
events.

Always enable toolbar when not disabled in options, even when all
elements on page have data-disable-toolbar set, it is possible that
elements are added later that require the toolbar.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 901ce97 on DMXzone:master into ** on yabwe:master**.

…extensions to update the editable html.

tests needed an update because the innerHTML of the content editable was
replaced after init.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 20dc823 on DMXzone:master into ** on yabwe:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3a9ee74 on DMXzone:master into ** on yabwe:master**.

… created after a enter to a p tag, this is now catched.

Fix for when applying block formatting when on a list item, it will
remove list formatting first.

fixed issue yabwe#1348
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling aac63d4 on DMXzone:master into ** on yabwe:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e3706c2 on DMXzone:master into ** on yabwe:master**.

@derekpitt
Copy link

Any updates on this getting merged in? I'm especially interested in the fix for #1348

@steveetm
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants