Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add video reader #11

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: add video reader #11

merged 1 commit into from
Sep 27, 2024

Conversation

egorchakov
Copy link
Contributor

@koritsky
Copy link

Does it work with gpu?

@sandhawalia
Copy link
Contributor

sandhawalia commented Sep 27, 2024

for GPU : any reason not to use https://pypi.org/project/PyNvVideoCodec/ ?
for CPU : why not good'ol OpenCV since under the hood `video_reader-rs leveraged ffmpeg as well

@egorchakov
Copy link
Contributor Author

This is the CPU version, GPU one coming next.

@egorchakov
Copy link
Contributor Author

egorchakov commented Sep 27, 2024

@sandhawalia

for CPU : why not good'ol OpenCV since under the hood `video_reader-rs leveraged ffmpeg as well

  1. https://github.com/gcanat/video_reader-rs?tab=readme-ov-file#rocket-performance-comparison
  2. https://gitlab.com/jfolz/simplejpeg/blob/master/README.rst:

OpenCV is gigantic, only accepts Numpy arrays as input, and returns images as BGR instead of RGB.

@egorchakov egorchakov merged commit f2c0ff8 into main Sep 27, 2024
1 check passed
@egorchakov egorchakov deleted the feat/video-reader branch September 27, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants