Add check for program argument empty value

y-scope · Feb 4, 2025 · df31fe2 · df31fe2
1 parent a365d7b
commit df31fe2
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/src/spider/scheduler/scheduler.cpp b/src/spider/scheduler/scheduler.cpp
@@ -86,6 +86,17 @@ auto parse_args(
         }
 
         boost::program_options::notify(variables);
+
+        if (host.empty()) {
+            std::cerr << spider::core::cHostEmptyMessage << "\n";
+            return false;
+        }
+
+        if (storage_url.empty()) {
+            std::cerr << spider::core::cStorageUrlEmptyMessage << "\n";
+            return false;
+        }
+
         return true;
     } catch (boost::program_options::error& e) {
         std::cerr << "spider_scheduler: " << e.what() << "\n";

diff --git a/src/spider/utils/ProgramOptions.hpp b/src/spider/utils/ProgramOptions.hpp
@@ -32,6 +32,8 @@ constexpr std::string_view cHostOption = {"host"};
 
 constexpr std::string_view cHostMessage = {"The host address to bind to"};
 
+constexpr std::string_view cHostEmptyMessage = {"The host address should not be empty"};
+
 constexpr std::string_view cPortOption = {"port"};
 
 constexpr std::string_view cPortMessage = {"The port to listen on"};
@@ -40,10 +42,15 @@ constexpr std::string_view cStorageUrlOption = {"storage-url"};
 
 constexpr std::string_view cStorageUrlMessage = {"The storage server's URL"};
 
+constexpr std::string_view cStorageUrlEmptyMessage
+        = {"The storage server's URL should not be empty"};
+
 constexpr std::string_view cLibsOption = {"libs"};
 
 constexpr std::string_view cLibsMessage = {"The tasks libraries to load"};
 
+constexpr std::string_view cLibsEmptyMessage = {"The tasks libraries should not be empty"};
+
 constexpr std::string_view cFunctionOption = {"func"};
 
 constexpr std::string_view cFunctionMessage = {"The function to execute"};

diff --git a/src/spider/worker/worker.cpp b/src/spider/worker/worker.cpp
@@ -99,6 +99,22 @@ auto parse_args(
         }
 
         boost::program_options::notify(variables);
+
+        if (host.empty()) {
+            std::cerr << spider::core::cHostEmptyMessage << "\n";
+            return false;
+        }
+
+        if (storage_url.empty()) {
+            std::cerr << spider::core::cStorageUrlEmptyMessage << "\n";
+            return false;
+        }
+
+        if (libs.empty()) {
+            std::cerr << spider::core::cLibsEmptyMessage << "\n";
+            return false;
+        }
+
         return true;
     } catch (boost::program_options::error& e) {
         std::cerr << "spider_worker: " << e.what() << "\n";