feat(clp-s): Add an initialization method in SchemaReader that passes the column map to FilterClass. #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis update introduces a new method Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant SR as SchemaReader
participant F as Filter
C->>SR: initialize_filter_with_column_map(filter)
SR->>F: init(this, schema_id, column_map)
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
wraymo
force-pushed
the
schemareader_initialize_filter_with_column_map
branch
2 times, most recently
from
0bb5cc6 to
60e0ee3
Compare
gibber9809
requested changes
Feb 5, 2025
| @@ -32,6 +32,18 @@ class FilterClass { | |||
| std::vector<BaseColumnReader*> const& column_readers | |||
| ) = 0; | |||
|
|
|||
| /** | |||
| * Initializes the filter with a column map | |||
There was a problem hiding this comment.
Suggested change
| * Initializes the filter with a column map | |
| * Initializes the filter with a column map. | |
| * Note: the column map only contains the ordered columns in a schema. |
| @@ -180,6 +192,12 @@ class SchemaReader { | |||
| */ | |||
| void initialize_filter(FilterClass* filter); | |||
|
|
|||
| /** | |||
| * Initializes the filter with a column map | |||
There was a problem hiding this comment.
Suggested change
| * Initializes the filter with a column map | |
| * Initializes the filter with a column map. | |
| * Note: the column map only contains the ordered columns in a schema. |
wraymo
force-pushed
the
schemareader_initialize_filter_with_column_map
branch
from
5d07d8a to
00ab770
Compare
…ze_filter_with_column_map
…ze_filter_with_column_map
gibber9809
approved these changes
Feb 6, 2025
wraymo
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing a new
FilterClass, sometimes it's more efficient to do a column ID lookup ifFilterClasscan access the column map. This PR adds a method inSchemaReaderto pass the column map toFilterClassChecklist
breaking change.
Validation performed
Summary by CodeRabbit