Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-tidy warnings for all C++ source files #96

Open
LinZhihao-723 opened this issue Nov 26, 2024 · 1 comment · Fixed by #95
Open

Fix clang-tidy warnings for all C++ source files #96

LinZhihao-723 opened this issue Nov 26, 2024 · 1 comment · Fixed by #95
Labels
enhancement New feature or request

Comments

@LinZhihao-723
Copy link
Member

LinZhihao-723 commented Nov 26, 2024

Request

Until 0c66d04, we have clang-tidy added to the linting tasks but disabled due to unresolved clang-tidy warnings across all C++ source files.
We should gradually resolve all these warnings.

Possible implementation

We shall send a serious of PRs to fix the warnings. Before all warnings are fixed, we should modify the lint task to only execute clang-tidy against fixed files (as discussed here). Eventually, we should have warnings resolved across all files, and we can set the lint task to run on all files (back to the config in 0c66d04)

New linting changes introduced to fix linting issues:

@LinZhihao-723
Copy link
Member Author

clang-tidy enabled in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant