You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Until 0c66d04, we have clang-tidy added to the linting tasks but disabled due to unresolved clang-tidy warnings across all C++ source files.
We should gradually resolve all these warnings.
Possible implementation
We shall send a serious of PRs to fix the warnings. Before all warnings are fixed, we should modify the lint task to only execute clang-tidy against fixed files (as discussed here). Eventually, we should have warnings resolved across all files, and we can set the lint task to run on all files (back to the config in 0c66d04)
New linting changes introduced to fix linting issues:
Request
Until 0c66d04, we have clang-tidy added to the linting tasks but disabled due to unresolved clang-tidy warnings across all C++ source files.
We should gradually resolve all these warnings.
Possible implementation
We shall send a serious of PRs to fix the warnings. Before all warnings are fixed, we should modify the lint task to only execute clang-tidy against fixed files (as discussed here). Eventually, we should have warnings resolved across all files, and we can set the lint task to run on all files (back to the config in 0c66d04)
New linting changes introduced to fix linting issues:
Py_utils
. #95wrapped_dependency_headers
in parallel toclp_ffi_py
Python.hpp
introduced in feat: Add Python classKeyValuePairLogEvent
as a wrapper ofclp::ffi::KeyValuePairLogEvent
. #81:clp_ffi_py
whenCLP_FFI_PY_ENABLE_LINTING
is definedutils
. #101PyKeyValuePairLogEvent
. #108.The text was updated successfully, but these errors were encountered: