Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: kirkrodrigues <[email protected]>
  • Loading branch information
LinZhihao-723 and kirkrodrigues authored Dec 3, 2024
1 parent 93a21ba commit e6e1fad
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ set(CLP_FFI_PY_LIB_IR_SOURCES
${CLP_FFI_PY_LIB_SRC_DIR}/utils.hpp
)

# NOTE: These headers are wrappers of third-party dependency libraries. They are required to silence
# clang-tidy warnings for missing direct includes.
# NOTE: These headers are third-party facade headers wrapped with IWYU exports to resolve clang-tidy
# violations for missing direct includes.
set(CLP_FFI_PY_WRAPPED_DEPENDENCY_HEADERS
${CLP_FFI_PY_WRAPPED_DEPENDENCY_HEADERS_DIR}/msgpack.hpp
${CLP_FFI_PY_WRAPPED_DEPENDENCY_HEADERS_DIR}/Python.hpp
Expand Down
3 changes: 1 addition & 2 deletions src/clp_ffi_py/.clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ IncludeCategories:
# Third-party headers. Update when adding new third-party library
- Regex: "<(clp|gsl|json|outcome)"
Priority: 3
# Third-party headers with wrappers to silent clang-tidy warnings. Update when adding new
# third-party library
# Third-party facade headers wrapped with IWYU exports to resolve clang-tidy violations
- Regex: "<wrapped_dependency_headers"
Priority: 3
# C headers
Expand Down
2 changes: 1 addition & 1 deletion src/wrapped_dependency_headers/msgpack.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#ifdef CLP_FFI_PY_ENABLE_LINTING
// Inform IWYU of the headers that we use that are exported by msgpack.hpp
// IWYU pragma: begin_exports
// TODO: add necessary msgpack internal headers to silent clang-tidy warnings
// TODO: Add necessary msgpack internal headers to silence clang-tidy warnings
// IWYU pragma: end_exports
#endif
// clang-format on

0 comments on commit e6e1fad

Please sign in to comment.