refactor: Fix clang-tidy warnings in ir_native.cpp. (#104)

y-scope · Dec 7, 2024 · b15c040 · b15c040
1 parent b1cbedb
commit b15c040
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lint-tasks.yml b/lint-tasks.yml
@@ -112,6 +112,7 @@ tasks:
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/api_decoration.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/error_messages.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/ExceptionFFI.hpp"
+            - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/modules"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.cpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.hpp"
             - "{{.CLP_FFI_PY_CPP_SRC_DIR}}/PyExceptionContext.hpp"

diff --git a/src/clp_ffi_py/modules/ir_native.cpp b/src/clp_ffi_py/modules/ir_native.cpp
@@ -18,7 +18,8 @@ PyDoc_STRVAR(
         "Python interface to the CLP IR serialization and deserialization methods."
 );
 
-// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays)
+// NOLINTBEGIN(cppcoreguidelines-avoid-non-const-global-variables)
+// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays, modernize-avoid-c-arrays)
 PyMethodDef Py_native_method_table[]{{nullptr, nullptr, 0, nullptr}};
 
 PyModuleDef Py_native{
@@ -28,9 +29,11 @@ PyModuleDef Py_native{
         -1,
         static_cast<PyMethodDef*>(Py_native_method_table)
 };
+
+// NOLINTEND(cppcoreguidelines-avoid-non-const-global-variables)
 }  // namespace
 
-// NOLINTNEXTLINE(modernize-use-trailing-return-type)
+// NOLINTNEXTLINE(modernize-use-trailing-return-type, readability-identifier-naming)
 PyMODINIT_FUNC PyInit_native() {
     PyObject* new_module{PyModule_Create(&Py_native)};
     if (nullptr == new_module) {

diff --git a/src/wrapped_facade_headers/Python.hpp b/src/wrapped_facade_headers/Python.hpp
@@ -25,6 +25,7 @@
 #include <memoryobject.h>
 #include <methodobject.h>
 #include <modsupport.h>
+#include <moduleobject.h>
 #include <object.h>
 #include <objimpl.h>
 #include <pyerrors.h>