Skip to content

Commit

Permalink
Don't use a global variable
Browse files Browse the repository at this point in the history
  • Loading branch information
LinZhihao-723 committed Dec 2, 2024
1 parent 0922962 commit 3ad685b
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions lint-tasks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ vars:
G_LINT_VENV_CHECKSUM_FILE: "{{.BUILD_DIR}}/lint#venv.md5"
# Linter target dirs
G_CPP_LINT_DIRS: ["{{.CLP_FFI_PY_CPP_SRC_DIR}}"]
G_CPP_STATIC_CHECK_SRC_FILES:
# TODO: Before all clang-tidy violations are resolved, we should only run clang-tidy on the
# files whose violations we've fixed, both to ensure they remain free of violations and so that
# the workflow doesn't fail due to violations in other files.
- "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.cpp"
- "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.hpp"
G_PYTHON_LINT_DIRS: ["{{.ROOT_DIR}}/clp_ffi_py", "{{.ROOT_DIR}}/tests"]

tasks:
Expand Down Expand Up @@ -109,7 +103,11 @@ tasks:
--config-file "{{.CLP_FFI_PY_CPP_SRC_DIR}}/.clang-tidy"
-p "{{.CLP_FFI_PY_COMPILE_COMMANDS_DB}}"
SRC_PATHS:
ref: ".G_CPP_STATIC_CHECK_SRC_FILES"
# TODO: Before all clang-tidy violations are resolved, we should only run clang-tidy on
# the files whose violations we've fixed, both to ensure they remain free of violations
# and so that the workflow doesn't fail due to violations in other files.
- "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.cpp"
- "{{.CLP_FFI_PY_CPP_SRC_DIR}}/Py_utils.hpp"
VENV_DIR: "{{.G_LINT_VENV_DIR}}"

py-check:
Expand Down

0 comments on commit 3ad685b

Please sign in to comment.