Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable exception catching; Separate build targets for node and worker environments. #11

Merged
merged 21 commits into from
Nov 1, 2024
Merged

Enable exception catching; Separate build targets for node and worker environments. #11

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
333dd2c
Enable exception catching with CMake "Debug" build type.
junhaoliao Oct 1, 2024
3b18e26
Separate targets for different environments such as `worker` and `node`.
junhaoliao Oct 5, 2024
9cdcb3b
Update target names in Taskfile.yml.
junhaoliao Oct 5, 2024
4bd6677
Update "exports" in package.json to include the new "node" target.
junhaoliao Oct 5, 2024
9000016
Specify "module" type in `package.json`.
junhaoliao Oct 5, 2024
990fd0c
Pass `-fwasm-exceptions` to also the compiler in addition to linker.
junhaoliao Oct 5, 2024
34ca552
Merge remote-tracking branch 'yscope/main' into enable-exception
junhaoliao Oct 5, 2024
27337c8
Remove leading slash in files[]."dist" in package.json .
junhaoliao Oct 5, 2024
b6b4dba
Revert commented out "Unix Makefiles" generator enforcement.
junhaoliao Oct 5, 2024
d6d7327
Add EOL to EOF in CMakeLists.txt .
junhaoliao Oct 5, 2024
3d2b3df
Merge branch 'main' into enable-exception
junhaoliao Oct 8, 2024
33565a8
Rename `CLP_FFI_JS_ENVIRONMENTS` -> `CLP_FFI_JS_SUPPORTED_ENVIRONMENT…
junhaoliao Oct 8, 2024
7607a9e
Refactor compile and link options generations; add missing `-flto` in…
junhaoliao Oct 8, 2024
48a9910
Add missing `-sENVIRONMENT=${env}` option into CLP_FFI_JS_LINK_OPTIONS.
junhaoliao Oct 8, 2024
c0f4d68
Update docs in CMakeLists.txt
junhaoliao Oct 8, 2024
3f9775b
Put list items on new lines - Apply suggestions from code review
junhaoliao Oct 31, 2024
d3caf42
Add period to log message - Apply suggestions from code review
junhaoliao Oct 31, 2024
ad8f9c4
Move compile and link options log after adding the options.
junhaoliao Oct 31, 2024
6df29f3
Remove `G_CLP_FFI_JS_TARGET_NAMES` and make `G_CLP_FFI_JS_ENV_NAMES` …
junhaoliao Oct 31, 2024
3d7a40f
Remove extra hyphen in `package` command.
junhaoliao Oct 31, 2024
340cca5
Add extra line - Apply suggestions from code review
junhaoliao Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ if(CMAKE_BUILD_TYPE MATCHES "Release")
-sENVIRONMENT=worker
)
else()
set(CLP_FFI_JS_EXTRA_LINKER_FLAGS -sENVIRONMENT=node)
set(CLP_FFI_JS_EXTRA_LINKER_FLAGS
-sENVIRONMENT=node
-sNO_DISABLE_EXCEPTION_CATCHING
junhaoliao marked this conversation as resolved.
Show resolved Hide resolved
)
endif()
message(
"CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}: Extra linker flags: ${CLP_FFI_JS_EXTRA_LINKER_FLAGS}"
Expand Down