Improvements to the library #55
Conversation
…ull` and `Undefined` values
…put.Undefined` property
… `stateVector` values
… `StateDiffV1()` and `StateDiffV2()` in the `Transaction` class
…orrect native method
LSViana
force-pushed
the
for-pr
branch
3 times, most recently
from
5a7077e
to
0dbb59c
Compare
There was a problem hiding this comment.
@SebastianStehle After discussions about the changes, code updates, and fixing tests, I'm merging this PR into the main repository.
|
Wow. Did you really take my work on the build pipeline and not credit me at all? i spent quite a bit of time on that. |
|
Hi, @goldsam! Wait, I'm sorry if that happened. I merged Sebastian's So, just to clarify, do you mean the pipeline setup that was added by Sebastian or me? I can most definitely add you as one of the authors. I just wasn't aware of it before so I'm sorry for putting you in the position of having to ask for that. |
|
Just the pipeline setup. I spent a lot of time and trial and error getting it working to support a wide range of platforms. Just disappointed that I didn't get at least a little credit 😢 |
|
This was not intended. I wanted to have something quick for my PR, so I copied from you what I understood and made some things differently, what I did not understand. and because a wide range of reasons the PR became too big. I am not sure if there are some big differences or if I have made something worse. |
|
@goldsam @SebastianStehle I added the authors as a comment to all the |
|
I really appreciate you trying to make this right. That was very considerate of you. 😉 |
As discussed, I have created a new PR. I have documented the changes in a separate file: https://github.com/SebastianStehle/ydotnet/blob/for-pr/docs/decision.md