New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SELECT ON #293

Merged

xzkostyan merged 1 commit into xzkostyan:master from aronbierbaum:add_distinct_on

Mar 4, 2024

Contributor

aronbierbaum commented Feb 21, 2024

fixes SADeprecationWarning: DISTINCT ON is currently supported only by the PostgreSQL dialect. #234

Checklist:

Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
Add or update relevant docs, in the docs folder and in code.
Ensure PR doesn't contain untouched code reformatting: spaces, etc.
Run flake8 and fix issues.
Run pytest no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.


          Add support for SELECT ON

a712772

coveralls commented Mar 4, 2024

coverage: 85.818% (-0.006%) from 85.824%
when pulling a712772 on aronbierbaum:add_distinct_on
into 46482bf on xzkostyan:master.

xzkostyan merged commit 2875475 into xzkostyan:master

60 of 79 checks passed

aronbierbaum deleted the add_distinct_on branch

March 22, 2024 18:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet