Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discover than requests like
select(table1).join(table2, table2.id == table1.table2Id).where([...])
didn't work with clickhouse-sqlalchemy but did work with standard sqlalchemy because
select(table1).join(table2, table2.id == table1.table2Id)
is aSelect
object in sqlalchemy2.This PR fix this (just changed the return of the
join
method) and add a test to prove the fix works.The diff in the test is massive because I added a for loop to test both ways to compute the join statement. Let me know if you think there is a better way to write the test
Checklist:
flake8
and fix issues.pytest
no tests failed. See https://clickhouse-sqlalchemy.readthedocs.io/en/latest/development.html.