Allow changing GoogleTagManager service status and id after init (#36)

* Allow changing GoogleTagManager service status and id after initialization This allows us to : - Support enabling/disabling gtm service by page in same website - Support injecting different gtm id by page in same website - Handle multiple gtm id for one website * Add more user friendly methods enable() and disable() to set service status (replace setEnabledStatus)
xyNNN · Apr 22, 2020 · e1214d8 · e1214d8
1 parent e293357
commit e1214d8
Show file tree

Hide file tree

Showing 4 changed files with 80 additions and 0 deletions.
diff --git a/Helper/GoogleTagManagerHelper.php b/Helper/GoogleTagManagerHelper.php
@@ -33,6 +33,22 @@ public function __construct(GoogleTagManagerInterface $service)
         $this->service = $service;
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function enable()
+    {
+        $this->service->enable();
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function disable()
+    {
+        $this->service->disable();
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -49,6 +65,14 @@ public function getId()
         return $this->service->getId();
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function setId($id)
+    {
+        $this->service->setId($id);
+    }
+
     /**
      * {@inheritdoc}
      */

diff --git a/Helper/GoogleTagManagerHelperInterface.php b/Helper/GoogleTagManagerHelperInterface.php
@@ -19,6 +19,16 @@
  */
 interface GoogleTagManagerHelperInterface extends HelperInterface
 {
+    /**
+     * @return void
+     */
+    public function enable();
+
+    /**
+     * @return void
+     */
+    public function disable();
+
     /**
      * @return bool
      */
@@ -29,6 +39,12 @@ public function isEnabled();
      */
     public function getId();
 
+    /**
+     * @param string $id
+     * @return void
+     */
+    public function setId($id);
+
     /**
      * @return array
      */

diff --git a/Service/GoogleTagManager.php b/Service/GoogleTagManager.php
@@ -76,6 +76,22 @@ public function mergeData($key, $value)
         $this->setData($key, array_merge_recursive($merge, $value));
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function enable()
+    {
+        $this->enabled = true;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function disable()
+    {
+        $this->enabled = false;
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -92,6 +108,14 @@ public function getId()
         return $this->id;
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function setId($id)
+    {
+        $this->id = $id;
+    }
+
     /**
      * {@inheritdoc}
      */

diff --git a/Service/GoogleTagManagerInterface.php b/Service/GoogleTagManagerInterface.php
@@ -38,6 +38,16 @@ public function setData($key, $value);
      */
     public function mergeData($key, $value);
 
+    /**
+     * @return void
+     */
+    public function enable();
+
+    /**
+     * @return void
+     */
+    public function disable();
+
     /**
      * @return bool
      */
@@ -48,6 +58,12 @@ public function isEnabled();
      */
     public function getId();
 
+    /**
+     * @param string $id
+     * @return void
+     */
+    public function setId($id);
+
     /**
      * @return array
      */