Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Status checks in commit message #171

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

marcin-lawrowski
Copy link
Contributor

@marcin-lawrowski marcin-lawrowski commented Apr 23, 2016

Fixes #131

It's a WIP

@marcin-lawrowski
Copy link
Contributor Author

@westonruter I consider this as done. Please take a look. Thanks!

@westonruter
Copy link
Contributor

I've installed the prepare-commit-msg locally and I'll give it a try!

@westonruter
Copy link
Contributor

@marcin-lawrowski I made a commit and it produced a somewhat unexpected result for the PHPCS rules listed:

Fix PHP notice generated when adding nav menu items

PHP 5.6.18 Syntax Check: Passed
PHP_CodeSniffer WordPress-Core
-------
WordPress-Docs
-------
Squiz.Commenting.FunctionComment.ScalarTypeHintMissing Check: Passed
PHPUnit Tests: Passed

This was in the context of the Customize Posts repo: https://github.com/xwp/wp-customize-posts

I think the logic for creating a list of rules needs to be improved. Either that, or I'd suggest just using the filename for the PHPCS ruleset would be fine and maybe better.

@marcin-lawrowski
Copy link
Contributor Author

OK @westonruter I fixed it. Now only the filename is included in commit message.

Previously I tried to parse that file and list all the standards found in "ref" attribute.

@westonruter
Copy link
Contributor

@marcin-lawrowski yes, that was smart… it was just too smart in this case 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants