This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Issue #207 : Rename 'Save & Publish' button #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Weston suggested in #35547, overwrite api.l10n.save. While the Customizer initially loads, the value (text) of the button is 'Save & Publish'. In about.5 seconds. it replaces this with 'Saved.'
kienstra
changed the title
|
Thanks, but per #207 (comment) I think we'll need to mull over this some more. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request For Review
Hi @westonruter,
Could you please see this pull request for #207 , which sets a new name for the
'Save & Publish'button? It's'Save'for the moment, pending whatever name you'd like to give it.As you suggested in #35547, this overwrites
api.l10n.save. When the Customizer initially loads, the value (text) of the button is'Save & Publish'. In about 500 milliseconds, it replaces this with'Saved'.As you know, this
'Save & Publish'text is originally produced with PHP in customize.php#L117. So if we'd like to prevent it from appearing at all, it would have to be overwritten with JavaScript earlier than it’s already overwritten, which I think is in customize-controls.js#L3908.