Fix local environment path #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delawski
approved these changes
Aug 8, 2024
Co-authored-by: Piotr Delawski <[email protected]>
Co-authored-by: Piotr Delawski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1545
Fixes the path to the plugin file and adds e2e tests which show the network admin UI in the network activated and deactivated states.
It also introduces a setup step for the e2e tests which logs a user in as admin and deactivates the plugin so we know which state we're in when starting the tests.
To run all of the e2e tests, use
npm run tests-e2eChecklist
contributing.md).Release Changelog
$this->plugin->is_network_activated()works correctly now on local environments.