XWIKI-22121: Improve the registration experience #3633
Conversation
* Removed an escaping that wasn't needed and caused a test to not pass. * Updated the test to work with the updated Registration template * Fixed a XPath on AbstractRegistrationPage.java to be more permissive and work with the latest changes.
| AbstractRegistrationPage.JOHN_SMITH_USERNAME), | ||
| assertEquals(String.format("%s%s %s (%s)%s", messagePrefix, firstName, lastName, | ||
| AbstractRegistrationPage.JOHN_SMITH_USERNAME, | ||
| !closedWiki&&withRegistrationConfig ? "" : ": Registration successful."), |
There was a problem hiding this comment.
That feels weird, you're sure it's expected to not have "Registration successful" in close wiki?
There was a problem hiding this comment.
@surli
Tbh this is more or less hardcoded to fit the results.
This set of conditions is the only one where the template defined in Registration.xml is used. I did update this template in the rework, the Registration successful string is in a separate element. I did not update the other templates, so for the moment the templates are not consistent with one another.
My guess is that if the wiki is closed the guest does not have access to this template and we rely on a public template somewhere else. This template is the default value when we set the registrationConfig, so I guess it's not used if the withRegistrationConfig is false.
* Added a TODO
|
For reference, I created the ticket https://jira.xwiki.org/browse/XWIKI-22648 on jira for this TODO and improvements of this test. |
|
thanks |
Jira URL
https://jira.xwiki.org/browse/XWIKI-22121
Changes
Description
Screenshots & Video
None, mostly test changes
Executed Tests
Successfully passed
mvn clean install -f xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker -Dit.test=RegisterIT. Before the changes proposed in this PR I could reproduce locally the fails found on CI with this command.Expected merging strategy