XWIKI-19383: Display a title on createlink

xwiki-platform-core/xwiki-platform-appwithinminutes/xwiki-platform-appwithinminutes-ui/src/main/resources/AppWithinMinutes/ClassEditSheet.xml

@@ -256,7 +256,10 @@ xcontext.put('propertyCustomDisplayer', new PropertyCustomDisplayer(xcontext))
     #set ($action = 'create')
     #set ($discard = $params.put('parent', $doc.fullName))
   #end
-  <span class="$class"><a href="$escapetool.xml($xwiki.getURL($reference, $action, $escapetool.url($params)))"
+  <span class="$class">
+  <a href="$escapetool.xml($xwiki.getURL($reference, $action, $escapetool.url($params)))"
+  title="$services.localization.render('platform.',
+    ['#pageLink($translationsReference)']"
     >$escapetool.xml($reference.name)</a></span>##
 #end
 

xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources.properties

@@ -793,6 +793,7 @@ core.create.name.hint=Name of the new page
 core.create.name.placeholder=NewPage
 
 core.create.template=Template
+core.create.inline.label=Create page: {0}
 core.create.page.template.hint=Template to use for the new page
 core.create.page.template.empty=Empty Wiki Page
 core.create.template.allowedspaces=Pages created from the template [{0}] must be created in one of the following spaces: {1}

xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/pom.xml

@@ -52,6 +52,11 @@
       <artifactId>xwiki-platform-template-api</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.xwiki.platform</groupId>
+      <artifactId>xwiki-platform-localization-api</artifactId>
+      <version>${project.version}</version>
+    </dependency>
     <dependency>
       <groupId>org.xwiki.platform</groupId>
       <artifactId>xwiki-platform-bridge</artifactId>

xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/renderer/XWikiDocumentURITitleGenerator.java

@@ -0,0 +1,61 @@
+/*
+ * See the NOTICE file distributed with this work for additional
+ * information regarding copyright ownership.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.xwiki.rendering.internal.renderer;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.xwiki.component.annotation.Component;
+import org.xwiki.model.reference.PageAttachmentReference;
+import org.xwiki.model.reference.PageAttachmentReferenceResolver;
+import org.xwiki.rendering.listener.reference.ResourceReference;
+import org.xwiki.localization.ContextualLocalizationManager;
+import org.xwiki.rendering.renderer.reference.link.URITitleGenerator;
+
+/**
+ * Generate link titles for ATTACH URIs.
+ *
+ * @version $Id$
+ * @since 15.2RC1
+ */
+@Component(hints = {"doc", "page"})
+@Singleton
+public class XWikiDocumentURITitleGenerator implements URITitleGenerator
+{
+    @Inject
+    private ContextualLocalizationManager contextLocalization;
+
+    /**
+     * Used to extract the attachment name part in an Attachment reference.
+     */
+    @Inject
+    @Named("current")
+    private PageAttachmentReferenceResolver<String> currentAttachmentReferenceResolver;
+
+    @Override
+    public String generateCreateTitle(ResourceReference reference)
+    {
+        PageAttachmentReference attachmentReference =
+            this.currentAttachmentReferenceResolver.resolve(reference.getReference());
+        return this.contextLocalization.getTranslationPlain("core.create.inline.label",
+         attachmentReference.getName());
+    }
+}

xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/resources/META-INF/components.txt

@@ -1,6 +1,7 @@
 500:org.xwiki.rendering.internal.renderer.XWikiAttachmentURILabelGenerator
 500:org.xwiki.rendering.internal.renderer.XWikiLinkLabelGenerator
 500:org.xwiki.rendering.internal.renderer.XWikiPageAttachmentURILabelGenerator
+500:org.xwiki.rendering.internal.renderer.XWikiDocumentURITitleGenerator
 500:org.xwiki.rendering.internal.util.XWikiErrorBlockGenerator
 500:org.xwiki.rendering.internal.wiki.XWikiWikiModel
 500:org.xwiki.rendering.internal.macro.XWikiHTMLRawBlockFilter

xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/displayer_page.vm

@@ -55,9 +55,14 @@
     ## The view displayer generates HTML so we need to escape the XML special characters from the page reference.
     $escapetool.xml($pageReference)
   #else
-    #set ($title = $escapetool.xml($pageDoc.plainTitle))
+    #set ($title = $escapetool.velocity($pageDoc.plainTitle))
     #if ($pageDoc.isNew())
-      <span class="wikicreatelink"><a href="$pageDoc.getURL('create')">$title</a></span>
+      <span class="wikicreatelink">
+        <a href="$pageDoc.getURL('create')"
+          title="$escapetool.xml($services.localization.render('core.create.inline.label', [$title]))">
+          $title
+        </a>
+      </span>
     #else
       <a href="$pageDoc.URL">$title</a>
     #end