Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDOCKER-87: Automatically build SOLR docker image with compose #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ASHISH932
Copy link
Contributor

No description provided.

* Created solr docker image template
* Edited build.gradle to use solr template
@ASHISH932
Copy link
Contributor Author

FTR:
build.gradle
template/solr/Dockerfile
template/solr/docker-compose.yml
template/solr/solr-init.sh (same as in contrib/solr)

@vmassol vmassol self-assigned this Jul 9, 2019
@vmassol
Copy link
Member

vmassol commented Aug 1, 2019

Note: this PR supersedes #14

@vmassol
Copy link
Member

vmassol commented Aug 1, 2019

This PR was discussed on matrix (https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$1564651451225975nhSFW:matrix.org?via=matrix.xwiki.com&via=matrix.org&via=matrix.wina.be). The conclusion is:

  • We don't need a custom SOLR image for XWiki. We should use the official SOLR image and configure it for XWiki using a compose file for example.
  • However, it's interesting to have a example of such a compose file in the github repo and in the doc
  • It's also interesting to make the xwiki image easily configurable to use an external solr instance (by exposing a "docker run" command line parameter for that).

Thanks @ASHISH932 !

@vmassol
Copy link
Member

vmassol commented Sep 10, 2019

ping @ASHISH932 about my last comment. Are you active on this PR? What's your plan? Thx!

@ASHISH932
Copy link
Contributor Author

Currently, I'm not working on this PR but would possibly update it later. Since our conclusion is to create a docker-compose file only, so the changes would happen in README file only. So if you want to close the PR, for now, you could.

@vmassol
Copy link
Member

vmassol commented Sep 11, 2019

I don't think the change is only a README change. See above where I mentioned:

It's also interesting to make the xwiki image easily configurable to use an external solr instance (by exposing a "docker run" command line parameter for that).

Otherwise how do you set it in a compose file?

@ASHISH932
Copy link
Contributor Author

This parameter is already exposed. We can use external solr with our container
https://github.com/xwiki-contrib/docker-xwiki/blob/master/README.md#using-an-external-solr-service

Is that what you mean ?

@vmassol
Copy link
Member

vmassol commented Sep 11, 2019

This parameter is already exposed. We can use external solr with our container
https://github.com/xwiki-contrib/docker-xwiki/blob/master/README.md#using-an-external-solr-service

Is that what you mean ?

Indeed, I guess it was done in a different PR.

Note: The doc doesn't explain how the solr.remote property is set so that could be improved in the doc but it's minor.

So I agree it's only doc that's remaining.

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants