FILEMAN-44: Add a checkbox on top of others to check them all #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -266,6 +268,9 @@ | |||
|
|
|||
| // Update the live table whenever the parameters are modified. | |||
| scope.$watch('params', function(newValue, oldValue) { | |||
| if(newValue.offset != oldValue.offset){ | |||
| scope.selection = {}; | |||
| } | |||
There was a problem hiding this comment.
This is not good. Don't reset the selection when the user moves to a different page. The user must be able to execute batch operations (like copy or delete) on files that are displayed on different pages. I want to be able to select a file, move to the next page, select a second file and then click Copy to copy both files (so including the file that I selected on the previous page).
* Improve checkboxes synchronization. * Create ngIndeterminate directive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.