Implement support for TimeZone information + General enhancements

[arjanmels]

• Add support for Timezones
• Included all locales that are available from CLDR
• Changed includes to improve compile times when only limited number of locales is used (breaking change)
• Improved documentation

[xvrh]

Thanks a lot. It looks great 👍

The only small thing I'm not 100% sure is the "common_locale_data_all.dart" library. I would not have bothered with that and the explanation around it. But if you think it's useful to you, then why not.

[xvrh]

Also, I think CommonLocaleData.en reads better than CommonLocaleDataEn(). I hope that with static extension method we could be able to add back the en getter with the separate imports.

Maybe we could make CommonLocaleData a globale variable and use normal extension method on them.

class CommonLocaleDataHolder {
}

final CommonLocaleData = CommonLocaleDataHolder();

// in en.dart
extension CommonLocaleDataEnExtension on CommonLocaleDataHolder {
  CommonLocaleData get en => CommonLocaleDataEn();
}

That way, we have the CommonLocaleData.en available only when we import the "en.dart" file.

Not the most beautiful. Maybe we could repurpose the cld variable for that (e.g. cld.en).

[arjanmels]

Thanks a lot. It looks great 👍

The only small thing I'm not 100% sure is the "common_locale_data_all.dart" library. I would not have bothered with that and the explanation around it. But if you think it's useful to you, then why not.

Not very useful for myself, but a convenience if you want to include ALL locales dynamically (which will result in several 10MB file size).

[arjanmels]

Agree the previous syntax looked nicer. (Also minor niggle is that the CommonLocaleDataEn() will create a new object reach time: these objects are very small as most members are statics, but not 100% elegant.)

I'm not sure the extension methods will work with statics (you can only call them on the extension method name, not the original class name and you cannot have multiple extensions with the same name).

I haven't found a more elegant way that both keeps the tree shaking and good compile times.

[arjanmels]

I fixed the dead code and unnecessary import warning that the build was failing on.

[arjanmels]

@xvrh Not sure if you got time to look at this pull request again? Are there further changes needed, to allow you to merge this change?

[xvrh]

Merged with #14