fix: 🧩 修复框架没有被正常作为依赖安装的问题 #322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uaenaTzx
reviewed
May 22, 2025
| @@ -240,7 +240,7 @@ class Generator { | |||
| // 单独处理一个框架相关依赖，主要是将框架相关的依赖包插入到pkg内，以及将需要的构建工具配置合并到构建工具模板中 | |||
| async templateGenerate() { | |||
| const templatePath = `packages/core/dist/template/template-${this.templateName}/generator/index.js`; | |||
| const templateGenerator = await this.loadBase(templatePath, ""); | |||
| const templateGenerator = getDefaultExport(await this.loadBase(templatePath, "")); | |||
There was a problem hiding this comment.
这个改动影响了其他的插件加载，所以最好回归测试一下，看看其他插件有没有被影响结果
| @@ -10,116 +10,107 @@ importers: | |||
| devDependencies: | |||
| '@commitlint/cli': | |||
| specifier: ^18.4.3 | |||
| version: 18.6.1(@types/[email protected])([email protected]) | |||
There was a problem hiding this comment.
pnpm lock 怎么会更新呢，你没改相关依赖。从改动上来看是node、pnpm版本有些问题，这个要对齐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information