-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify code to handle non-standard and time-varying component orientations #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dip." This reverts commit 75c4696.
…cross different time periods.
Hi Shangqin, |
xumi1993
approved these changes
Jan 19, 2025
Got it. I will submit a pull request to your dev branch the next time I modify the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for providing this package, which has significantly improved the efficiency of my PRF processing.
I made two changes in this pull request:
Correction to SAC Header
cmpinc
CalculationThe relationship between the
dip
defined in the SEED standard and the SAC headercmpinc
should becmpinc = dip + 90
rather than the previously assumedcmpinc = −dip
. While this error does not impact data using standard NEZ components, it becomes significant when rotating non-standard components to NEZ, where correct "dip" values are required. To address this, I modified the rotateZNE function in eq.py and the _add_header function in rf.py.Handling Time-Varying Component Orientations
The original
_add_header
function could not correctly process stations with component orientations that vary over time (e.g., station II.MSVF). I updated this function to determine the appropriate orientation based on the correct time period for each station.I tested the updated code using station II.MSVF, which has non-standard and time-varying component orientations:
Thank you for reviewing this pull request, and I look forward to your feedback!