Skip to content

Commit

Permalink
scripts/git: Stop running the checked-out git scripts
Browse files Browse the repository at this point in the history
Stop executing the checked-out pre-commit hook from the pre-push hook.
Instead, execute the copy in the user's git dir.

Fixes bug 33284; bugfix on 0.4.1.1-alpha.
  • Loading branch information
teor2345 committed Feb 12, 2020
1 parent 41a9edd commit 99d9576
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
4 changes: 4 additions & 0 deletions changes/bug33284
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
o Minor bugfixes (git scripts):
- Stop executing the checked-out pre-commit hook from the pre-push hook.
Instead, execute the copy in the user's git dir. Fixes bug 33284; bugfix
on 0.4.1.1-alpha.
9 changes: 7 additions & 2 deletions scripts/git/pre-push.git-hook
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ z40=0000000000000000000000000000000000000000

upstream_name=${TOR_UPSTREAM_REMOTE_NAME:-"upstream"}

# The working directory
workdir=$(git rev-parse --show-toplevel)
# The .git directory
# If $workdir is a worktree, then $gitdir is not $workdir/.git
gitdir=$(git rev-parse --git-dir)

cd "$workdir" || exit 1

Expand Down Expand Up @@ -58,7 +62,8 @@ do
fi

# Call the pre-commit hook for the common checks, if it is executable
if [ -x scripts/git/pre-commit.git-hook ]; then
pre_commit=${gitdir}/hooks/pre-commit
if [ -x "$pre_commit" ]; then
# Only check the files newly modified in this branch
CHECK_FILTER="git diff --name-only --diff-filter=ACMR $range"
# Use the appropriate owned tor source list to filter the changed
Expand All @@ -81,7 +86,7 @@ do
# We want word splitting here, because file names are space
# separated
# shellcheck disable=SC2086
if ! scripts/git/pre-commit.git-hook $CHECK_FILES ; then
if ! "$pre_commit" $CHECK_FILES ; then
exit 1
fi
fi
Expand Down

0 comments on commit 99d9576

Please sign in to comment.