unittest: pass Non IDR frame to decode after flush #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuguangxin
reviewed
Dec 26, 2016
decoder/DecoderApi_unittest.cpp
Outdated
| int32_t inFrames = 0; | ||
| int32_t outFrames = 0; | ||
|
|
||
| for (int i = 0; i < size; i++) { |
There was a problem hiding this comment.
This will flush every frame, it does not simulate the real case. It's better to change to this: Suppose we have N frame, we flush the decoder at frame 1 and play to end, seek to begin and flush at frame 2 ..etc
|
@xuguangxin updated！ |
this is used to verify yami's robustness Signed-off-by: Linda Yu <[email protected]>
if the frist frame of a new stream is not idr, return invalid data directly but not process it. Signed-off-by: Linda Yu <[email protected]>
Signed-off-by: Linda Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is used to verify yami's robustness
Signed-off-by: Linda Yu [email protected]