ocl: implement alpha blending #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +57,11 @@ libyami_vpp_cppflags = \ | |||
| $(NULL) | |||
|
|
|||
| if BUILD_OCL_BLENDER | |||
| libyami_vpp_ldflags += -lOpenCL | |||
There was a problem hiding this comment.
is any possible to find a portable way, since it maybe not a x64 platform
|
is it possible use this one instead hard code path. |
| ret = YAMI_FAIL; | ||
| goto err_cl; | ||
| } | ||
| clFlush(cmd_q); |
dspmeng
force-pushed
the
ocl_blend
branch
4 times, most recently
from
533759d
to
103e5fe
Compare
|
Update according to review comments. Please review. |
| } | ||
| bufferInfo.mem_type = VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME; | ||
| if (VA_STATUS_SUCCESS != vaAcquireBufferHandle(m_display, clImage.image.buf, &bufferInfo)) { | ||
| ERROR("vaAcquireBufferHandle failed"); |
There was a problem hiding this comment.
if we failed here. the image will leaked.
|
Address review comments and rebase to latest ocl_blend. |
| @@ -56,6 +58,124 @@ YamiStatus OclPostProcessBase::ensureContext(const char* kernalName) | |||
| return YAMI_SUCCESS; | |||
| } | |||
|
|
|||
| YamiStatus OclPostProcessBase::createCLImage(const SharedPtr<VideoFrame>& frame, | |||
There was a problem hiding this comment.
you can return SharedPtr directly.
|
ok to me, please send pull request to 01.org/libyami |
android's libva driver need this
we did not clear reflist0/1 for I frame, android driver will crash on this
else valgrind will complain use uninit value at L922
android's libva require this for csc
android's libva require use set the color standard.
Set sequence params to driver for every frame, else driver may crash when encoding some small size videos. Signed-off-by: Zhong Li <[email protected]>
Because only short term reference supported right now, set all reference pictures to be short term. Signed-off-by: Zhong Li <[email protected]>
This patch is to fix android encoding driver crash when encoding 1920x1080 videos. Signed-off-by: Zhong Li <[email protected]>
1. Add multi-reference frames interface and test cases 2. Add multi-reference frames support for h264 and hevc. Because of current reoder mechanism, multi-reference is only used for forward reference. The max value of back referece frames is still one. Signed-off-by: Zhong Li <[email protected]>
it make sure we can get width height after vppinputdecode configed
we do not need clean back ground for scaler, and it will make whole screen black when we use NV12 as dest, RGBX have no this problem, because there are some issue in opensource libva driver.
OclPostProcessBlender do not inhert from VaapiPostProcessBase more over, not all sub class deriver from VaapiDecoderBase or VaapiEncoderBase so make sure factory return IVideoXXX is better
libva's alpha blending have limited support, it only supports src&dest have same size. It's inconvenience for real word application. We'd better enable opencl based vpp functions. It also a step stone for other vpp operation. such as rotation,flips...etc
it's just a bare-bone application to test all base class works. it waiting for opencl kernels.
an alpha blending application to render random color blocks on a video.
* import cl image from VASurfaceID in ocl vpp base class * add opencl kernel for alpha blending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is hard code in vpp/Makefile.am for Beignet libcl.so include path, because Beignet doesn't provide pkg-config .pc file. Any suggestion?