Merge pull request #95 from juliano-souza000/fix/non_en_us_date_time_…

…parse Fix non en-US date time parse
xtyxtyx · Nov 3, 2024 · 2458805 · 2458805
2 parents dc821b8 + dc82296
commit 2458805
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/lib/src/utils.dart b/lib/src/utils.dart
@@ -122,13 +122,13 @@ String trimDoubleQuote(String str) {
 }
 
 DateTime parseRfc7231Time(String time) {
-  final format = DateFormat('EEE, dd MMM yyyy HH:mm:ss');
+  final format = DateFormat('EEE, dd MMM yyyy HH:mm:ss', 'en-US');
   final isUtc = time.endsWith('GMT');
   return format.parse(time, isUtc);
 }
 
 String toRfc7231Time(DateTime time) {
-  final format = DateFormat('EEE, dd MMM yyyy HH:mm:ss');
+  final format = DateFormat('EEE, dd MMM yyyy HH:mm:ss', 'en-US');
   final result = format.format(time);
   return time.isUtc ? '$result GMT' : result;
 }

diff --git a/test/utils_test.dart b/test/utils_test.dart
@@ -1,5 +1,7 @@
 import 'dart:typed_data';
 
+import 'package:intl/date_symbol_data_local.dart';
+import 'package:intl/intl.dart';
 import 'package:minio/src/utils.dart';
 import 'package:test/test.dart';
 
@@ -25,6 +27,20 @@ void testRfc7231Time() {
       expect(parseRfc7231Time(timeStringUtc), equals(timeUtc));
       expect(parseRfc7231Time(timeStringUtc).isUtc, isTrue);
     });
+
+    test(
+      'works for non en-US locale', () async {
+        initializeDateFormatting('pt_BR');
+        Intl.withLocale(
+          'pt_BR',
+          ()
+          {
+            expect(parseRfc7231Time(timeStringUtc), equals(timeUtc));
+            expect(parseRfc7231Time(timeStringUtc).isUtc, isTrue);
+          }
+        );
+      }
+    );
   });
 
   group('toRfc7231Time', () {
@@ -35,6 +51,19 @@ void testRfc7231Time() {
     test('works for GMT time', () {
       expect(toRfc7231Time(timeUtc), equals(timeStringUtc));
     });
+
+    test(
+      'works for non en-US locale', () async {
+        initializeDateFormatting('pt_BR');
+        Intl.withLocale(
+          'pt_BR',
+          ()
+          {
+            expect(toRfc7231Time(timeUtc), equals(timeStringUtc));
+          }
+        );
+      }
+    );
   });
 }