Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlcmd path updated for the newest MsSQL image #575

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

dcihak
Copy link
Contributor

@dcihak dcihak commented Aug 26, 2024

In the latest MSSQL Docker image (2022-latest refering to 2022-CU14-ubuntu-20.04) the path to sqlcmd was changed. This causes probe error during the start.

Tracked by the mssql-docker issue.

Related XTF issue #573.

Copy link
Contributor

@simkam simkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documented directly in https://hub.docker.com/r/microsoft/mssql-server

Starting with SQL Server 2022 CU 14, we are updating SQL Server 2022 container images to include the new mssql-tools18 package. With the introduction of SQL Server 2022 CU 14, and in all future container images, the previous directory /opt/mssql-tools/bin will be phased out. The new directory for Microsoft ODBC 18 tools will be '/opt/mssql-tools18/bin', aligning with the latest tools offering. For additional details on all the changes and security enhancements, please refer to the blog post ODBC Driver 18.0 for SQL Server Released - Microsoft Community Hub⁠. This new iteration, ODBC driver version 18, is designed with an ‘encryption-first’ approach, ensuring that utilities like sqlcmd and bcp that utilize the Microsoft ODBC driver will operate under the ‘secure by default’ principle. Users who wish to disable encryption will need to do so explicitly.

I don't see a need to stay compatible with older image versions.

Copy link
Contributor

@mnovak1 mnovak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging even though this might cause some issues in case users are still on older hardcoded version of mssql image. They need to either update the mssql image or override the probe settings to old location.

@mnovak1 mnovak1 merged commit 8375ab6 into xtf-cz:master Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants