Feature/electron cooler #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 11, 2023 13:51
|
Sorry for reopening the old pull request, but I was having some trouble with my vscode. The new test takes less time to run and it is ready to be merged. |
|
Closed by mistake |
|
Closed by mistake |
|
Fixed the merge conflicts and reran all the tests. All the tests passed so it is ready to be merged. |
|
Hey Gianni, Could you please review and merge this pull request? It would be convenient for others who are waiting to use electron cooler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redid Pull request: Feature/electron cooler #335
I have added an ElectronCooler beam element to Xtrack. The cooler uses the Parkhomchuk model.
Checklist
Mandatory:
Optional: