Skip to content

Commit

Permalink
Merge pull request eclipse#153 from xstefank/spec-fix
Browse files Browse the repository at this point in the history
Fix spec text inconsistencies
  • Loading branch information
antoinesd authored Dec 7, 2018
2 parents 6c07daa + 721c40d commit b4e0d33
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion spec/src/main/asciidoc/java-api.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public abstract class HealthCheckResponse {

The status of all `HealthCheck` 's determines the overall status.

== Constructing `HealthCheckResponse`s
== Constructing `HealthCheckResponse` 's

Application level code is expected to use one of static methods on `HealthCheckResponse` to retrieve a `HealthCheckResponseBuilder` used to construct a response, i.e. :

Expand Down
4 changes: 2 additions & 2 deletions spec/src/main/asciidoc/overview.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ all of the procedure health status.

The 1.0 version of the MP-HC specification does not define how the `/health` endpoint may be partitioned in the event
that the MicroProfile runtime supports deployment of multiple applications. If an implementation wishes to
support multiple applications within a MicroProfile runtime, the semantics of the /health endpoint are
support multiple applications within a MicroProfile runtime, the semantics of the `/health` endpoint are
expected to be the logical AND of all the application in the runtime. The exact details of this are deferred to
a future version of the MP-HC specification.

Expand All @@ -60,4 +60,4 @@ The proposed solution breaks down into two parts:
- Heiko Rupp
- Antoine Sabot-Durand
- Scott Stark
- Kevin Sutter
- Kevin Sutter
6 changes: 3 additions & 3 deletions spec/src/main/asciidoc/protocol-wireformat.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ signal the overall status)

==== REST/HTTP interaction

* Producer MUST provide a HTTP endpoint that follow the REST interface specifications described in Appendix A
* Producer MUST provide a HTTP endpoint that follows the REST interface specifications described in Appendix A.

==== Protocol Adaptor

Expand Down Expand Up @@ -154,7 +154,7 @@ When executing health check procedures a producer MUST handle any unchecked exce
Aspects regarding the secure access of health check information.

* A producer MAY support security on all health check invocations (i.e. authentication)
* A producer MUST not enforce security by default, it SHOULD be an opt-in feature (i.e. configuration change)
* A producer MUST NOT enforce security by default, it SHOULD be an opt-in feature (i.e. configuration change)

== Appendix A: REST interface specifications

Expand Down Expand Up @@ -343,4 +343,4 @@ Status `503` and the following payload:
"status": "DOWN",
"checks": []
}
```
```

0 comments on commit b4e0d33

Please sign in to comment.