Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run analysis for min supported flutter version #112

Merged
merged 2 commits into from
Nov 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/giffy_dialog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ jobs:
uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/semantic_pull_request.yml@v1

build:
strategy:
matrix:
flutter-version:
# The version of Flutter to use should use the minimum Dart SDK version supported by the package,
# refer to https://docs.flutter.dev/development/tools/sdk/releases.
- "3.16.0"
- "3.x"
runs-on: ubuntu-latest
steps:
- name: 📚 Git Checkout
Expand All @@ -25,8 +32,10 @@ jobs:
- name: 🐦 Setup Flutter
uses: subosito/flutter-action@v2
with:
flutter-version: ${{matrix.flutter-version}}
channel: stable
cache: true
cache-key: flutter-:os:-:channel:-:version:-:arch:-:hash:-${{ hashFiles('**/pubspec.lock') }}

- name: 📦 Install Dependencies
run: flutter packages get
Expand Down Expand Up @@ -64,6 +73,7 @@ jobs:
with:
channel: stable
cache: true
cache-key: flutter-:os:-:channel:-:version:-:arch:-:hash:-${{ hashFiles('**/pubspec.lock') }}

- name: 📁 Build and release
uses: bluefireteam/flutter-gh-pages@v8
Expand Down
2 changes: 1 addition & 1 deletion lib/src/giffy_bottom_sheet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class GiffyBottomSheet extends StatelessWidget {

/// Creates an giffy bottom sheet which uses a [RiveAnimation] as the [giffy].
const GiffyBottomSheet.rive(
RiveAnimation rive, {
rive.RiveAnimation rive, {
super.key,
this.giffyBuilder = defaultGiffyBuilder,
this.giffyPadding,
Expand Down
2 changes: 1 addition & 1 deletion lib/src/giffy_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class GiffyDialog extends StatelessWidget {

/// Creates a giffy dialog which uses a [RiveAnimation] as the [giffy].
const GiffyDialog.rive(
RiveAnimation rive, {
rive.RiveAnimation rive, {
super.key,
this.giffyBuilder = defaultGiffyBuilder,
this.giffyPadding,
Expand Down
2 changes: 1 addition & 1 deletion lib/src/giffy_modal.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import 'dart:ui';

import 'package:flutter/material.dart';
import 'package:lottie/lottie.dart';
import 'package:rive/rive.dart' hide Image;
import 'package:rive/rive.dart' as rive;

import 'entry_animation.dart';

Expand Down