Test unexpected events when translating SSE to WebSockets

xp-forge · Jan 18, 2025 · 5d88f89 · 5d88f89
1 parent 0b88cf0
commit 5d88f89
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/main/php/xp/web/srv/TranslateMessages.class.php b/src/main/php/xp/web/srv/TranslateMessages.class.php
@@ -60,7 +60,7 @@ public function message($conn, $message) {
             $conn->close();
             break;
           }
-          default: throw new IllegalStateException('Unexpected event '.$event);
+          default: throw new IllegalStateException('Unexpected event from backend://'.$conn->path().': '.$event);
         }
       }
     } catch (Any $e) {

diff --git a/src/test/php/web/unittest/server/TranslateMessagesTest.class.php b/src/test/php/web/unittest/server/TranslateMessagesTest.class.php
@@ -102,6 +102,34 @@ public function close() {
     Assert::false($ws->isConnected());
   }
 
+  #[Test]
+  public function unexpected_type() {
+    $request= $this->message(
+      'POST /ws HTTP/1.1',
+      'Sec-WebSocket-Version: 9',
+      'Content-Type: text/plain',
+      'Content-Length: 4',
+      '',
+      'Test',
+    );
+    $response= $this->message(
+      'HTTP/1.1 200 OK',
+      'Content-Type: text/event-stream',
+      'Transfer-Encoding: chunked',
+      '',
+      "16\r\nevent: unknown\ndata: \n\r\n0\r\n\r\n"
+    );
+
+    $backend= new Channel([$response]);
+    $ws= new Channel([]);
+    $fixture= new TranslateMessages($backend);
+    $fixture->message(new Connection($ws, 1, null, '/ws', []), 'Test');
+
+    Assert::equals($request, implode('', $backend->out));
+    Assert::equals("\210\056\003\363Unexpected event from backend:///ws: unknown", implode('', $ws->out));
+    Assert::false($ws->isConnected());
+  }
+
   #[Test]
   public function backend_error() {
     $request= $this->message(