Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support fish speech reference audio #2542

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

codingl2k1
Copy link
Contributor

@XprobeBot XprobeBot added the enhancement New feature or request label Nov 11, 2024
@XprobeBot XprobeBot added this to the v0.16 milestone Nov 11, 2024
@qinxuye
Copy link
Contributor

qinxuye commented Nov 15, 2024

Is reference_audio in fish equivalent to prompt_speech in cosyvoice? I wonder if it's possible to reuse the option?

@codingl2k1
Copy link
Contributor Author

Is reference_audio in fish equivalent to prompt_speech in cosyvoice? I wonder if it's possible to reuse the option?

We can reuse the option, then users will need to pass prompt_speech instead of reference_audio. I am not sure which name is better.

@qinxuye
Copy link
Contributor

qinxuye commented Nov 15, 2024

Is reference_audio in fish equivalent to prompt_speech in cosyvoice? I wonder if it's possible to reuse the option?

We can reuse the option, then users will need to pass prompt_speech instead of reference_audio. I am not sure which name is better.

Yeah, we can unify the APIs since prompt_speech is added already, we can add it in doc that it can be used as reference_audio for fish speech.

@codingl2k1
Copy link
Contributor Author

Is reference_audio in fish equivalent to prompt_speech in cosyvoice? I wonder if it's possible to reuse the option?

We can reuse the option, then users will need to pass prompt_speech instead of reference_audio. I am not sure which name is better.

Yeah, we can unify the APIs since prompt_speech is added already, we can add it in doc that it can be used as reference_audio for fish speech.

I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fish-Speech启用reference-audio
3 participants