Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix flexible model register in worker #2011

Merged
merged 1 commit into from
Aug 4, 2024
Merged

BUG: fix flexible model register in worker #2011

merged 1 commit into from
Aug 4, 2024

Conversation

frostyplanet
Copy link
Contributor

@frostyplanet frostyplanet commented Aug 4, 2024 •
edited
Loading

Bug trigger only on non-local mode:

call register_model(model_type=flexible) on worker will raise Exception

File "/opt/inference/xinference/core/worker.py", line 573, in register_model
ValueError: [address=XXXX pid=7] not enough values to unpack (expected 4, got 3)

introduced from

commit 9bb548a6d98a7bf145cdbff76ae032aa9ccf9db1
Author: Wang Shenggong [[email protected]](mailto:[email protected])
Date:   Fri Jul 12 11:43:08 2024 +0800

    FEAT: Add support for Flexible Model (#1671)

@frostyplanet
Fix flexible model register in worker
8bf79bb 
Bug trigger only on non-local mode:

    File "/opt/inference/xinference/core/worker.py", line 573, in register_model
    ValueError: [address=112.28.49.214:9010, pid=7] not enough values to unpack (expected 4, got 3)
@XprobeBot XprobeBot added this to the v0.14.0 milestone Aug 4, 2024
@frostyplanet frostyplanet mentioned this pull request Aug 4, 2024
Merged
@qinxuye qinxuye changed the title Fix flexible model register in worker BUG: fix flexible model register in worker Aug 4, 2024
@XprobeBot XprobeBot added the bug Something isn't working label Aug 4, 2024
qinxuye
qinxuye approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 8e292b9 into xorbitsai:main Aug 4, 2024
13 checks passed
@frostyplanet frostyplanet deleted the fix_flexible_register branch September 18, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@frostyplanet @qinxuye @XprobeBot