Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following methods when the path is a directory:
The current implementation uses
File
, which is invalid for directories. When you try to invoke the method with a directory path, you'll get the following exception (.NET 8 and .NET FX 4.8):The XML documentation is not clear whether this should be supported or not. In the summary it says changing the file time:
zio/src/Zio/IFileSystem.cs
Lines 131 to 133 in ae0b1ca
But in the path-param it's saying it accepts files and directories:
zio/src/Zio/IFileSystem.cs
Line 134 in ae0b1ca
If we decide to merge this PR, should we change the XML documentation summary, so it mentions directories as well?