Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to gateway in-code #57

Merged
merged 9 commits into from
Feb 12, 2024
Merged

Remove references to gateway in-code #57

merged 9 commits into from
Feb 12, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 8, 2024

some housekeeping and one step closer to getting rid of the gateway moniker

@insipx insipx changed the title Remove references to gateway Remove references to gateway in-code Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2393a7) 91.16% compared to head (9e8627f) 91.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   91.16%   91.16%           
=======================================
  Files          12       12           
  Lines         419      419           
=======================================
  Hits          382      382           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insipx insipx requested review from tsachiherman and removed request for snormore February 8, 2024 21:56
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I'd just ask that you revert whitespace only changes unless that includes a code change.

.github/workflows/ghcr-image.yml Outdated Show resolved Hide resolved
@insipx
Copy link
Contributor Author

insipx commented Feb 9, 2024

What formatter are you using?

I'm using yamlfmt with default settings

@jac18281828
Copy link
Contributor

What formatter are you using?

I'm using yamlfmt with default settings

I added a note to try to set that up. I'll see how to get synced up.

Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All looks great! Appreciate the cleanup.

@37ng
Copy link
Contributor

37ng commented Feb 9, 2024

Are we planning to change the repo name from xps-gateway to xps?

@insipx
Copy link
Contributor Author

insipx commented Feb 9, 2024

Are we planning to change the repo name from xps-gateway to xps?

makes sense to me

I think either @jac18281828 or @snormore would have to make that change

@insipx insipx merged commit 18f851d into main Feb 12, 2024
6 checks passed
@insipx insipx deleted the insipx/xps-reorg branch February 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants