Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick followup fix for incremental compilation #40

Merged
merged 1 commit into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@ jobs:

- name: Build and Push
uses: docker/build-push-action@v3
env:
CARGO_INCREMENTAL: 0
with:
context: .
platforms: linux/amd64
push: false
build-args: |
VERSION=latest
CARGO_INCREMENTAL=0
3 changes: 1 addition & 2 deletions .github/workflows/ghcr-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,14 @@ jobs:
-
name: Build and Push
uses: docker/build-push-action@v3
env:
CARGO_INCREMENTAL: 0
with:
context: .
file: ./prod/Dockerfile
platforms: linux/amd64,linux/arm64
push: true
build-args: |
VERSION=${{ github.ref_name }}
CARGO_INCREMENTAL=0
tags: |
ghcr.io/${{ env.REPOSITORY_PATH }}:v${{ github.ref_name }}
ghcr.io/${{ env.REPOSITORY_PATH }}:${{ env.REPOSITORY_SHA }}
Expand Down
3 changes: 3 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM ghcr.io/xmtp/rust:latest
ARG CARGO_INCREMENTAL

USER xmtp

RUN sudo apt update && sudo apt install -y pkg-config openssl libssl-dev
Expand All @@ -10,6 +12,7 @@ COPY --chown=xmtp:xmtp . .
ENV PATH=~xmtp/.cargo/bin:$PATH
ENV USER=xmtp

ENV CARGO_INCREMENTAL=${CARGO_INCREMENTAL:-1}
RUN cargo check
RUN cargo fmt --check
RUN cargo clippy --all-features --no-deps -- -D warnings
Expand Down
Loading