Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33: method - status #34

Merged
merged 3 commits into from
Jan 17, 2024
Merged

33: method - status #34

merged 3 commits into from
Jan 17, 2024

Conversation

jac18281828
Copy link
Contributor

closes #33

Introduces a load balancer and status check for gateway to validate infrastructure deployment

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (77a1a11) 60.71% compared to head (7f93c79) 71.21%.

Files Patch % Lines
xps-gateway/src/rpc/methods.rs 72.72% 3 Missing ⚠️
xps-gateway/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
+ Coverage   60.71%   71.21%   +10.49%     
===========================================
  Files           9        9               
  Lines          56       66       +10     
===========================================
+ Hits           34       47       +13     
+ Misses         22       19        -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@insipx
Copy link
Contributor

insipx commented Jan 17, 2024

didn't mean to approve twice -- forgot i already reviewed it

@jac18281828
Copy link
Contributor Author

@insipx please take another look. I added documentation, converted the warnings to trigger build failure and added support for integration testing

@jac18281828 jac18281828 merged commit 7f93c79 into main Jan 17, 2024
5 checks passed
@jac18281828 jac18281828 deleted the jac/status branch January 17, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

JSON RPC Endpont: status
3 participants