Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coverage and extra debian deps #17

Merged
merged 6 commits into from
Jan 8, 2024
Merged

add coverage and extra debian deps #17

merged 6 commits into from
Jan 8, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Dec 22, 2023

closes #16 and #12

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@insipx insipx marked this pull request as ready for review December 22, 2023 22:35
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! This is really helpful. I'm sorry it took me so long to notice this over break! Sometimes deleting code is more satisfying that adding it 😅

As a suggestion for the future, it is a good idea to keep PRs limited to a single issue to prevent confusion and also to enable reverting out bad changes easily!

xps-gateway/tests/integration_test/mod.rs Outdated Show resolved Hide resolved
@insipx
Copy link
Contributor Author

insipx commented Jan 8, 2024

As a suggestion for the future, it is a good idea to keep PRs limited to a single issue to prevent confusion and also to enable reverting out bad changes easily!

Noted!

@insipx insipx merged commit 77a1a11 into main Jan 8, 2024
3 checks passed
@insipx insipx deleted the insipx/codecov branch January 8, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove protobuf
3 participants