Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (iOS) use batchQuery instead of one-at-a-time for messages #47

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

dmccartney
Copy link
Contributor

This replaces the placeholder implementation of batch-message-listing on iOS with an actual call to batchQuery.

This depends on landing and using xmtp/xmtp-ios#106

Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the unit tests still pass looks good to me!

@dmccartney dmccartney marked this pull request as ready for review June 3, 2023 01:44
@dmccartney dmccartney requested a review from a team as a code owner June 3, 2023 01:44
@dmccartney dmccartney merged commit d42be02 into main Jun 5, 2023
@dmccartney dmccartney deleted the daniel-actual-batch-ios branch June 5, 2023 19:27
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants