feat: support listBatchMessages (placeholder sequential) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccartney
force-pushed
the
daniel-batch-message-listing
branch
2 times, most recently
from
90d42fc
to
b099fee
Compare
dmccartney
changed the title
nplasterer
approved these changes
May 26, 2023
dmccartney
force-pushed
the
daniel-batch-message-listing
branch
from
b099fee
to
194cf95
Compare
dmccartney
commented
May 26, 2023
Comment on lines
+353
to
+355
| if (isDebugEnabled) { | ||
| Log.v("XMTPModule", msg); | ||
| } |
There was a problem hiding this comment.
added this in response to #45 (review)
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nplasterer
reviewed
May 30, 2023
Comment on lines
+167
to
+171
| .map { | ||
| it.messages(limit = limit, before = beforeDate, after = afterDate) | ||
| .map { DecodedMessageWrapper.encode(it) } | ||
| } | ||
| .flatten() |
There was a problem hiding this comment.
You can actually do this with a flatMap in Kotlin https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/flat-map.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP toward implementing #34.
listBatchMessagesin RN JSTo do in follow-up PRs
batchQueryso we can implement the performant edition in RN