Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit metrics for MLS sent messages #355

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Emit metrics for MLS sent messages #355

merged 2 commits into from
Feb 21, 2024

Conversation

snormore
Copy link
Contributor

Addresses part of #342

tsachiherman
tsachiherman approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neekolas
neekolas approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for adding this. We're definitely going to need to keep adding observability during the alpha.

New MLS E2E tests is somewhere on my agenda as well.

@snormore snormore merged commit fad7a17 into main Feb 21, 2024
3 checks passed
@snormore snormore deleted the snor/mls-sent-msg-metrics branch February 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

@tsachiherman tsachiherman tsachiherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snormore @neekolas @tsachiherman