Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Docs: Update repo readme and link content type READMEs to their related XIPs #19

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Docs: Update repo readme and link content type READMEs to their related XIPs #19

merged 1 commit into from
Jul 20, 2023

Conversation

jhaaaa
Copy link
Collaborator

@jhaaaa jhaaaa commented Jul 20, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

⚠️ No Changeset found

Latest commit: 4ecabad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jhaaaa jhaaaa merged commit 7e4f76d into main Jul 20, 2023
4 checks passed
nplasterer
nplasterer approved these changes Jul 20, 2023
View reviewed changes
packages/content-type-reply/README.md
@@ -2,6 +2,9 @@

This package provides an XMTP content type to support direct replies to messages.

> **Open for feedback**
> You are welcome to provide feedback on this implementation by commenting on the [Reply Content Type XIP](https://github.com/xmtp/XIPs/pull/22) (XMTP Improvement Proposal).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are actually encouraging people to comment in the discussion and not the XIP. https://github.com/orgs/xmtp/discussions/35

packages/content-type-reaction/README.md
@@ -2,6 +2,9 @@

This package provides an XMTP content type to support reactions to messages.

> **Open for feedback**
> You are welcome to provide feedback on this implementation by commenting on the [Reaction Content Type XIP](https://github.com/xmtp/XIPs/pull/23) (XMTP Improvement Proposal).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for reactions https://github.com/orgs/xmtp/discussions/36

@rygine rygine deleted the updt-readme branch October 10, 2024 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rygine rygine rygine approved these changes

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhaaaa @rygine @nplasterer