Smart contract wallet support #304
Merged
+3,573
−1,337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koleok
reviewed
Oct 3, 2024
…/xmtp/xmtp-android into np/smart-contract-wallet-support
neekolas
reviewed
Oct 15, 2024
library/src/androidTest/java/org/xmtp/android/library/TestHelpers.kt
Outdated
Show resolved
Hide resolved
nplasterer
commented
Oct 18, 2024
|
|
||
| val clientOptions = options ?: ClientOptions(enableV3 = true) | ||
| val accountAddress = | ||
| if (account.isSmartContractWallet) "eip155:${account.chainId}:${account.address.lowercase()}" else account.address.lowercase() |
There was a problem hiding this comment.
This was the fix for the Unknown Signer issue. We need to create the client with the CIAP address.
neekolas
reviewed
Oct 18, 2024
neekolas
reviewed
Oct 18, 2024
library/src/androidTest/java/org/xmtp/android/library/TestHelpers.kt
Outdated
Show resolved
Hide resolved
neekolas
reviewed
Oct 18, 2024
library/src/androidTest/java/org/xmtp/android/library/TestHelpers.kt
Outdated
Show resolved
Hide resolved
nplasterer
commented
Oct 19, 2024
| Branch: main | ||
| Date: 2024-10-08 19:58:58 +0000 | ||
| Version: 6937f233 | ||
| Branch: np/fix-ffi-bindings |
There was a problem hiding this comment.
The WASM branch broke the FFI bindings so had to roll back to the commit before the wasm branch.
|
Feel really good about this. I think it's ready for a final review. 
|
neekolas
approved these changes
Oct 21, 2024
neekolas
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for smart contract wallet accounts.