Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-1271 support and testing a partner wallet app. #609

Merged
merged 12 commits into from
Apr 8, 2024
Merged

Conversation

37ng
Copy link
Contributor

@37ng 37ng commented Apr 2, 2024

Adds ERC-1271 support and tests for open sourced coinbase smart wallet.

closes #608

@37ng 37ng requested a review from a team as a code owner April 2, 2024 00:03
xmtp_id/src/verifier.rs Outdated Show resolved Hide resolved
xmtp_id/src/verifier.rs Outdated Show resolved Hide resolved
@bwcDvorak bwcDvorak changed the title Coinbase Smart Wallet support. Partner app Smart Wallet support. Apr 2, 2024
Copy link
Contributor Author

@37ng 37ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@37ng
Copy link
Contributor Author

37ng commented Apr 5, 2024

Added integration tests for signature verification, owner revocation, time travel logic.
Please give another review

@37ng 37ng changed the title Partner app Smart Wallet support. ERC-1271 support and testing a partner wallet app. Apr 5, 2024
@37ng 37ng requested review from insipx and neekolas April 5, 2024 23:12
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good

@37ng 37ng enabled auto-merge (squash) April 8, 2024 17:04
@37ng 37ng merged commit abb1b73 into main Apr 8, 2024
7 checks passed
@37ng 37ng deleted the 37ng/verify-1271 branch April 8, 2024 17:09
@tuddman
Copy link
Contributor

tuddman commented Apr 8, 2024

Adding here that running our test suite locally breaks; added foundry and its bundled chain tool, Anvil to the dependency list. For anyone that hits the

failures:
    erc1271_verifier::tests::test_coinbase_smart_wallet

you need to install foundry with:

# get the installer
curl -L https://foundry.paradigm.xyz | bash

# `source` your shell environment. e.g
source ~/.zshenv

# install foundry  <- this will also install anvil as well as some other chain tools.
foundryup 

then run the tests again, and they should pass.

@37ng
Copy link
Contributor Author

37ng commented Apr 8, 2024

@tuddman Thanks! I wonder can we easily add foundry in the dev/up to automate this? I tried the scripts here but didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial Smart Wallet support - partner wallet app
4 participants