Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent State Group & Member Associations and Bindings #1057

Merged
merged 34 commits into from
Sep 13, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Sep 12, 2024

Part of #801
This adds the bindings for inserting consent as well as fetching it on members and groups.

  • Bindings for consent state on group
  • Bindings for consent state on member
  • Binding for adding consent state to a group
  • Binding for adding any consent (to help with bulk import/migration)
  • Binding for fetching consent for an address, id, or group id (to help with V2/V3 migration)

@nplasterer nplasterer self-assigned this Sep 12, 2024
Copy link

graphite-app bot commented Sep 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@nplasterer nplasterer marked this pull request as ready for review September 12, 2024 03:29
@nplasterer nplasterer requested a review from a team as a code owner September 12, 2024 03:29
@nplasterer
Copy link
Contributor Author

nplasterer commented Sep 12, 2024

I've got a lot of tests to write but would love some eyes on the approach I took here for consent.
Mostly trying to make it simple enough for getting the group or member consent quickly while also adding the legacy way to set and get to help with the dual sending period. Open to thoughts.

Copy link
Contributor

@insipx insipx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

bindings_ffi/src/mls.rs Outdated Show resolved Hide resolved
xmtp_mls/src/groups/mod.rs Outdated Show resolved Hide resolved
@nplasterer nplasterer requested review from insipx and a team September 13, 2024 03:16
@nplasterer nplasterer merged commit 7e70ad4 into main Sep 13, 2024
11 checks passed
@nplasterer nplasterer deleted the np/consent-bindings branch September 13, 2024 15:56
@nplasterer nplasterer mentioned this pull request Oct 3, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants